On Tue, Feb 26, 2008 at 02:03:14PM -0800, Danek Duvall wrote: > On Tue, Feb 26, 2008 at 11:30:30AM -0600, Nicolas Williams wrote: > > > http://cr.opensolaris.org/~nico/webrev-sqlite3-sfw-2nd/ > > In general, ident comments should look like normal comments, not pragmas -- > put the space in between the "#" and "ident". > > Makefile.sfw: > > - line 72: Why is this line necessary? INS.dir should take care of > getting the mode correct already.
Er, because at one time I'd also had targets that used INS.file to install the manpage and pkgIndex.tcl. I guess I can get rid of this. > - line 98 (and others): You shouldn't need to set -R/usr/lib. And > -L/usrlib is a) a typo and b) unnecessary. Argh, that was left over from me testing that LD_OPTIONS was being passed through by libtool. I'll remove this. > install-sfw: > > - line 88: The last argument probably needs a "$" in there somewhere. Yes, good catch! > - line 95: Probably want to put "Error:" here, too, so that nightly picks > up on the error. Will do. > What ends up in the runpath here by default, anyway? /usr/lib -- yeah, no runpath should be needed then, right? BTW, I needed fix_elf_runpath() because libtool was somehow adding $SRC/lib/libsqlite3/... to the runpath of libtclsqlite3 (but not to libsqlite3). Don't ask me why; I don't know why. > - line 109: space around the |. OK. > That's some badass elfedit-fu in reduce_symbol_scope, btw. Well, it turns out it doesn't do what you'd think it should. So I'll remove it altogether. I just won't reduce the scope of libsqlite3's non-exported symbols for now until we find out how best to deal with this. You can see the thread I started this afternoon about this on tools-linking at opensolaris.org if you like. Nico --
