On Tue, Feb 26, 2008 at 05:47:05PM -0600, Nicolas Williams wrote: > On Tue, Feb 26, 2008 at 02:03:14PM -0800, Danek Duvall wrote: > > On Tue, Feb 26, 2008 at 11:30:30AM -0600, Nicolas Williams wrote: > > > > > http://cr.opensolaris.org/~nico/webrev-sqlite3-sfw-2nd/ > > > > In general, ident comments should look like normal comments, not pragmas -- > > put the space in between the "#" and "ident". > > > > Makefile.sfw: > > > > - line 72: Why is this line necessary? INS.dir should take care of > > getting the mode correct already. > > Er, because at one time I'd also had targets that used INS.file to > install the manpage and pkgIndex.tcl. I guess I can get rid of this.
Removing it causes those dirs to be created with 0555. Setting DIRMODE=0555 doesn't fix it. Weird. I'll retain the FILEMODE setting. > > - line 88: The last argument probably needs a "$" in there somewhere. > > Yes, good catch! And further down in the same function there's another instance of this (which is why the whole thing worked). > > - line 109: space around the |. > > OK. Well, the function's gone now. Nico --
