On Tue, Feb 26, 2008 at 11:30:30AM -0600, Nicolas Williams wrote:
> http://cr.opensolaris.org/~nico/webrev-sqlite3-sfw-2nd/
In general, ident comments should look like normal comments, not pragmas --
put the space in between the "#" and "ident".
Makefile.sfw:
- line 72: Why is this line necessary? INS.dir should take care of
getting the mode correct already.
- line 98 (and others): You shouldn't need to set -R/usr/lib. And
-L/usrlib is a) a typo and b) unnecessary.
install-sfw:
- line 88: The last argument probably needs a "$" in there somewhere.
- line 95: Probably want to put "Error:" here, too, so that nightly picks
up on the error. What ends up in the runpath here by default, anyway?
- line 109: space around the |.
That's some badass elfedit-fu in reduce_symbol_scope, btw.
Danek
