On Fri, 2009-09-04 at 21:21 +0530, Spoorthy H S wrote: > Hi Mark, > > Here's the new webrev. http://cr.opensolaris.org/~spoorthy/ws_cryptcbc3/ > This is for perl 5.8.4. and BUGTRAQ field is not filled in [because they > are waiting for ARC approval] > Note that this crypt-cbc has the dependency on a package called > crypt-des. I have sent code review request.
Ok. Generally looks good! Just two minor nits: usr/src/lib/perl_crypt_cbc/METADATA:3 typo - "implemetation" usr/src/pkgdefs/SUNWperl-crypt-cbc/pkginfo.tmpl:46 CLASSES="none manifest" should probably be CLASSES="none" -M
