Spoorthy H S wrote:
> Thank you..
>
> I will include the package SUNWperl-crypt-des in
> usr/src/pkgdefs/SUNWperl-crypt-cbc/depend file once the package is
> done completely
The new webrev is at http://cr.opensolaris.org/~spoorthy/ws_cryptcbcd/
with final changes...
>
> Thanks
> Spoorthy
>
> Mark Phalan wrote:
>> On Fri, 2009-09-04 at 18:49 +0200, Mark Phalan wrote:
>>
>>> On Fri, 2009-09-04 at 21:21 +0530, Spoorthy H S wrote:
>>>
>>>> Hi Mark,
>>>>
>>>> Here's the new webrev.
>>>> http://cr.opensolaris.org/~spoorthy/ws_cryptcbc3/
>>>> This is for perl 5.8.4. and BUGTRAQ field is not filled in [because
>>>> they are waiting for ARC approval]
>>>> Note that this crypt-cbc has the dependency on a package called
>>>> crypt-des. I have sent code review request.
>>>>
>>> Ok. Generally looks good!
>>>
>>> Just two minor nits:
>>>
>>> usr/src/lib/perl_crypt_cbc/METADATA:3
>>> typo - "implemetation"
>>> usr/src/pkgdefs/SUNWperl-crypt-cbc/pkginfo.tmpl:46
>>> CLASSES="none manifest" should probably be
>>> CLASSES="none"
>>>
>>
>> Oh, one more thing. If there is a dependency on the crypt-des package it
>> needs to be in the depend file
>> usr/src/pkgdefs/SUNWperl-crypt-cbc/depend
>>
>> -M
>>
>>
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
