On 08/08/2011 04:21 PM, Robin Holt wrote: > On Mon, Aug 08, 2011 at 04:16:27PM +0200, Wolfgang Grandegger wrote: >> On 08/08/2011 03:56 PM, Robin Holt wrote: >>>> commit 65bb8b060a873fa4f5188f2951081f6011259614 >>>> Author: Bhaskar Upadhaya <[email protected]> >>>> Date: Fri Mar 4 20:27:58 2011 +0530 >>> >>> On a side note, that commit fixes up "fsl,flexcan-v1.0" >>> ... >>> + do_fixup_by_compat_u32(blob, "fsl,flexcan-v1.0", >>> + "clock_freq", gd->bus_clk, 1); >>> >>> Should I go back to flexcan-v1.0 in my patches? >> >> Well, no. Let's wait. I don't think we need it. Also, it sets >> "clock_freq" while >> >> >> http://lxr.linux.no/#linux+v3.0.1/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >> >> documents "clock-frequencies"... :-(. > > You answered a different question that I was asking. I was asking if > I should change fsl,flexcan back to fsl,flexcan-v1.0 as documented on > line 5. The clock_freq looks like a uboot change will need to be made > as well.
Well, I wrote above: "Well, no. Let's wait. I don't think we need it." For the P1010 we can sinmply derive the clock frequency from "fsl_get_sys_freq()", which is fine for the time being. No extra properties, etc. The clk implemetation might go into http://lxr.linux.no/#linux+v3.0.1/arch/powerpc/platforms/85xx/clock.c or http://lxr.linux.no/#linux+v3.0.1/arch/powerpc/sysdev/fsl_soc.c And may depend on HAVE_CAN_FLEXCAN BTW, I have not found HAVE_CAN_FLEXCAN in your patch. What kernel are you using? Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
