[
https://issues.apache.org/jira/browse/SOLR-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656534#action_12656534
]
Noble Paul commented on SOLR-913:
---------------------------------
bq.As mentioned earlier - this is a bottleneck got from profiling
Profiling tools alone cannot be used to make a judgment because they are dumb
and just spits out suggestions on the basis of a few rules. While it is useful,
we need to study the environment in which the code is run and a it is good to
have better understanding of a system to make relevant changes.
It is also worthwhile to run the system and see the real-world impact .
> org/apache/solr/handler/SnapPuller.java - Expensive Pattern object made
> static
> --------------------------------------------------------------------------------
>
> Key: SOLR-913
> URL: https://issues.apache.org/jira/browse/SOLR-913
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Environment: Tomcat 6, JRE 6
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-913.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In the class - org.apache.solr.handler.SnapPuller - there seems to be an
> expensive Pattern object created locally in the method
> static Integer readInterval(String interval) ;
> Pattern instances are better created as static objects and reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
