[ 
https://issues.apache.org/jira/browse/SOLR-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-913:
---------------------------------------

    Component/s:     (was: Analysis)
                 replication (java)
    Description: 
In the class -  org.apache.solr.handler.SnapPuller - there seems to be an 
expensive Pattern object created locally in the method 

  static Integer readInterval(String interval) ; 

Pattern instances are better created as static objects and reused.

The same is true for HttpClient instances. These are one per core right now. We 
can make that static too.




  was:
In the class -  org.apache.solr.handler.SnapPuller - there seems to be an 
expensive Pattern object created locally in the method 

  static Integer readInterval(String interval) ; 

Pattern instances are better created as static objects and reused. 




       Assignee: Shalin Shekhar Mangar

HttpClient can be made static too in that case.

> org/apache/solr/handler/SnapPuller.java  - Expensive Pattern object made 
> static 
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-913
>                 URL: https://issues.apache.org/jira/browse/SOLR-913
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>         Environment: Tomcat 6, JRE 6 
>            Reporter: Kay Kay
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-913.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In the class -  org.apache.solr.handler.SnapPuller - there seems to be an 
> expensive Pattern object created locally in the method 
>   static Integer readInterval(String interval) ; 
> Pattern instances are better created as static objects and reused.
> The same is true for HttpClient instances. These are one per core right now. 
> We can make that static too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to