[
https://issues.apache.org/jira/browse/SOLR-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657017#action_12657017
]
Kay Kay commented on SOLR-913:
------------------------------
Shalin - the new patch looks good. Thanks for helping with it.
Thanks everybody in the thread for the discussions regarding this.
> org/apache/solr/handler/SnapPuller.java - Expensive Pattern object made
> static
> --------------------------------------------------------------------------------
>
> Key: SOLR-913
> URL: https://issues.apache.org/jira/browse/SOLR-913
> Project: Solr
> Issue Type: Improvement
> Components: replication (java)
> Environment: Tomcat 6, JRE 6
> Reporter: Kay Kay
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-913.patch, SOLR-913.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In the class - org.apache.solr.handler.SnapPuller - there seems to be an
> expensive Pattern object created locally in the method
> static Integer readInterval(String interval) ;
> Pattern instances are better created as static objects and reused.
> The same is true for HttpClient instances. These are one per core right now.
> We can make that static too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
