http://bugzilla.spamassassin.org/show_bug.cgi?id=2853
------- Additional Comments From [EMAIL PROTECTED] 2004-05-24 15:46 -------
Subject: Re: [review] Rewrite masses/ (in perl)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Daniel Quinlan writes:
> > I'd suggest a further tweak, BTW: for the "masses" scripts that DAF is
> > talking about putting into a -tools pkg, I suggest we rename them to
> > use an "sa-" prefix. e.g. sa-mass-check, sa-hit-frequencies, et al.
> > This helps to keep them logically together when installed, and is
> > consistent with sa-learn. (we should probably do similar for the
> > "tools" scripts too eventually).
>
> Only rename them when installed, please!
No -- that's kind of pointless, because then any scripts or guidelines
for running mass-checks/perceptron etc. would work only for 1 style
or the other of installed or from masses dir.
> > I'd also suggest some renaming to be clearer about what they do in
> > reality, e.g.:
> >
> > mass-check sa-mass-scan
>
> current name seems fine.
IMO, "check" is too generic. it's scanning.
> > extract-message-from-mbox sa-mbox-get
>
> We have another script to do the same thing, "mboxget" which is
> generally easier to use, the only thing missing from it is the ability
> to read directly from a .log (which is just egrep -v '#'|awk '{print $3}').
good point.
> > hit-frequencies sa-msr-to-freqs
>
> "msr" is less clear to me.
>
> > lint-rules-from-freqs sa-rules-lint
> > logs-to-c sa-msr-compile
> > fp-fn-statistics sa-accuracy-report
>
> Can we also fix the FP and FN numbers? Only print the correct one! :-)
yes! good point. (drives me nuts, that one ;)
> You know, I'm not really in favor of mass-renaming stuff. Rename the
> things that are completely misnamed, but leave it at that.
it seems like a good opportunity to do this to me, IMO...
- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS
iD8DBQFAsnsoQTcbUG5Y7woRAk6oAKCoClyilqwklC5f8+VyK1kQgR4siwCeLWGY
jU8M7lPyXnHTgDmB32053zQ=
=gNX8
-----END PGP SIGNATURE-----
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
