http://bugzilla.spamassassin.org/show_bug.cgi?id=2853





------- Additional Comments From [EMAIL PROTECTED]  2004-05-24 22:48 -------
Subject: Re:  [review] Rewrite masses/ (in perl)


> Re: mboxget vs extract-message-from-mbox: I kinda merged the two
> scripts, so the extract-message-from-mbox as shown in the patch should
> be pretty much like the current mboxget + it has the ability to read
> mass-check logs

Okay.  Let's name the final script "mboxget".  The other name is out of
control length-wise (for something I run so often).
 
> Re: adding sa- prefix: I'm relatively indifferent on this. It's
> probably a good idea, although I was originally planning on having
> them put into /usr/share/spamassassin-tools rather than /usr/bin to
> avoid cluttering the namespace.

I like your original plan MUCH better.  I don't think adding sa-* to
anything we don't actively intend users to run is a good idea and these
scripts are far from there, that's a post-3.0 thing.

> Renaming them makes them more accessible. So I'll vote for renaming
> (and only renaming the ones that are going to be distributed). I'm not
> currently distributing the scripts in tools, although I may wish to
> now (we should probably rename them then)

No.  -1 on renaming.
 
> Re: mass-check vs mass-scan: I like the ring to mass-check better, but
> mass-scan is probably more logical.

mass-check :-)
 
> Re: FP/FN numbers: I'm not sure what you're talking about. btw
> fp-fn-statistics is essentially what logs-to-c --count used to be.

There is more than one number reported.  The one we want is FP / (all
ham) and FN / (all spam).  (IIRC, it's the second one on the line.)
 
> Re: MSR: I agree there should be a better name, but I'm not sure this
> is it. But in the absence of a better suggestion....

Something like "results".  No incomprehensible acronyms.
 
> Someone want to give me another +1 so I can commit what I've got and we can
> worry about the rest later, or do you feel you want to see another patch?

-0.1 only because I want to see another patch.





------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Reply via email to