http://bugzilla.spamassassin.org/show_bug.cgi?id=3331
------- Additional Comments From [EMAIL PROTECTED] 2004-08-13 06:53 -------
Subject: Re: [review] Bayes option to keep original token as db data (not key).
It's all of the sanity checking, for instance:
In tok_pack:
+ # raw_token should be limited to 128 characters and should not be
undefined
+ $raw_token = (defined($raw_token) ? substr($raw_token, 0, 128) :
'');
In tok_sync_counters:
+ # if a $raw_token didn't get passed in, but there was one set keep
the original
+ # but only if we want to store the original token. This allows raw
token values
+ # to filter out of the database when the option gets turned off.
+ if (!$raw_token &&
$self->{bayes}->{conf}->{bayes_store_original_token}) {
+ $raw_token = $orig_raw_token;
+ }
+
In tok_count_change:
+ $raw_token = '' unless (defined($raw_token));
+
Sometimes $raw_token is checked 3-4 times before it finally gets
packed. It needs to be that way because of the spaghetti code in
DBM.pm. If we backed up and cleaned up the internal methods a little
we might could make things better.
Michael
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
