http://bugzilla.spamassassin.org/show_bug.cgi?id=3331





------- Additional Comments From [EMAIL PROTECTED]  2004-08-13 11:50 -------
Subject: Re:  [review] Bayes option to keep original token as db data (not key).

-1 on the patch and feature

Believe me, I don't really like doing it, I spent a large amount of
time coding it up and testing/benchmarking it all, but I feel it needs
to be done.

Even after a call for comments on the -users list there was little
comment and no one coming forward with a compelling reason for keeping
the token values around.

The patch in it's best case causes a 3-4% slowdown, for some things
it's a 45-48% slowdown.  Even stripping out what I would call critical
sanity checking code there is a 1-2% slowdown and I'm no longer
confident in the data being stored in the database.

Perhaps it's enough to have done the patch and placed it in this bug
report, then when someone comes up with a reason we can refer them to
the patch and they can apply it locally.  Obviously it wouldn't be
officially maintained, but that doesn't mean someone else couldn't
maintain the patch and re-attach as needed.

Michael





------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Reply via email to