@miconda commented on this pull request.


> @@ -1855,11 +1856,8 @@ int tps_db_update_dialog(
        }
        if((mode & TPS_DBU_TIME)
                        && ((sd->b_tag.len > 0) && (msg->first_line.type == 
SIP_REQUEST)
-                                       && (((md->direction == TPS_DIR_UPSTREAM)
-                                                               && 
(msg->first_line.u.request.method_value
-                                                                               
== METHOD_SUBSCRIBE))
-                                                       || 
((msg->first_line.u.request.method_value
-                                                                       == 
METHOD_INVITE))))) {
+                                       && 
(msg->first_line.u.request.method_value
+                                                       == 
_tps_methods_update_time))) {

The match on `method_value` has to be a bitwise `&`, not `==`, otherwise it 
won't match any if it is more than one method type in the module parameter.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4561#pullrequestreview-3699148794
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4561/review/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to