On Thu, Jun 16, 2016 at 04:36:47AM +0300, Dmitry V. Levin wrote:
> On Wed, Jun 15, 2016 at 12:43:00PM +0000, Fabien Siron wrote:
[...]
> > +void
> > +decode_netlink(struct tcb *tcp, unsigned long addr, unsigned long size)
> > +{
> > +   struct nlmsghdr nlmsghdr;
> > +
> > +   if (size < sizeof(struct nlmsghdr)) {
> > +           printaddr((unsigned long)addr);
> 
> addr is of type unsigned long, no need to cast.

Besides that, it's more appropriate to printstr instead of printaddr,
like with non-netlink sockets.


-- 
ldv

Attachment: pgp5WsrnPXqci.pgp
Description: PGP signature

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to