On Thu, Jun 16, 2016 at 01:22:12PM +0000, Fabien Siron wrote:
> Quoting Dmitry V. Levin (2016-06-16 01:36:47)
> > On Wed, Jun 15, 2016 at 12:43:00PM +0000, Fabien Siron wrote:
[...]
> As verbose must be used instead of show_fd_path, the following seems better:
>
> switch (verbose(tcp) ? getfdproto(tcp, fd) : SOCK_PROTO_UNKNOWN) {
Agreed.
> > > @@ -947,10 +975,11 @@ SYS_FUNC(recv)
> > > printfd(tcp, tcp->u_arg[0]);
> > > tprints(", ");
> > > } else {
> > > - if (syserror(tcp))
> > > + if (syserror(tcp)) {
> >
> > What's this?
>
> printsockbuf() must be called if there is no syserror. What's wrong with that?
There is an inconsistent change of coding style along with the actual
code change: brackets are added to the "if" part of the statement only.
> > > diff --git a/netlink.c b/netlink.c
> > > new file mode 100644
> > > index 0000000..30116dd
> > > --- /dev/null
> > > +++ b/netlink.c
> > > +static bool
> > > +_decode_netlink(struct tcb *tcp, void *elem_buf, size_t elem_size,
> >
> > names starting with underscore are reserved and shouldn't be used.
>
> Do you prefer something like "print_netlink_iov"?
I don't have a strong preference in this case, as I'm now in favour
of extending tprint_iov_upto to handle netlink.
--
ldv
pgpj8B7WI4zsE.pgp
Description: PGP signature
------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
