Quoting Dmitry V. Levin (2016-06-16 13:38:06)
> On Thu, Jun 16, 2016 at 01:26:15PM +0000, Fabien Siron wrote:
> > Quoting Dmitry V. Levin (2016-06-16 10:08:22)
> > > Alternatively, rather than making decode_netlink_iov work like
> > > tprint_iov_upto, you can extend tprint_iov_upto to print netlink related
> > > data.  For example, "decode_iov" argument of tprint_iov_upto can be turned
> > > from de-facto boolean printaddr/printstr value into enum.
> > 
> > I think that this is a good idea but as all the functions that call
> > tprint_iov_upto() or tprint_iov() must be patched, it's maybe better to do
> > that as a seperated commit (maybe a future improvement).
> 
> Yes, a separate commit is a good idea.
> 

The problem is that we may want to add some arguments in the future
to decode_netlink_msg() for further parsing (either the protocol or the
file descriptor at least) and tprint_iov_upto()
doesn't seem to be able to transmit some arguments.

Regards,
--
Fabien Siron

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to