Quoting Dmitry V. Levin (2016-06-15 17:36:35) > On Wed, Jun 15, 2016 at 12:42:59PM +0000, Fabien Siron wrote: > > This commit aims to avoid future string comparisons with getfdproto function > > in changing its return type. It also adapts the functions that use it. > > I'm not quite sure what does the first sentence mean.
Do you prefer "This commit introduces a new type (sock_proto) which replaces strings for socket protocols."? > > > * defs.h (print_sockaddr_by_inode, get_proto_by_name): Add. > > Only get_proto_by_name is a new prototype, print_sockaddr_by_inode was > there before the change. > > > (sock_proto): New enum. > > * socketutils.c (print_sockaddr_by_inode): Move proto to int. > > I'm not quite sure what does "Move proto to int" mean. Do you prefer "Convert proto argument to sock_proto type."? > > -- > ldv > > Regards, -- Fabien Siron ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381 _______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
