[
http://www.stripesframework.org/jira/browse/STS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11939#action_11939
]
Nikolaos commented on STS-751:
------------------------------
Timothy Stone said:
> However, while correcting the NPE, nested Layout Components do not see the
> PageContext of the LayoutDefinition and cannot see the xhtml flag, true or
> false. This > can be corrected, however, I am just becoming familiar with the
> source code. Maybe someone can run with this as a foundation.
The problem you describe is fortunately not a Stripes issue but a Java
implementation issue. In Java here is PAGE, REQUEST, SESSION and APPLICATION
scopes and each of the respective scopes I listed expands its reach over the
previous one. So instead of PAGE scope the next scope up is REQUEST and that
will allow any variables set to be available for the life of the "request" (not
for the life of the "page" which you have now) which is exactly what you need
in this case as layouts and renders appear on separate pages but are all part
of the same request.
The solution is trivial... simply replace all of your occurrences of:
PageContext.PAGE_SCOPE with: PageContext.REQUEST_SCOPE
That "should" solve the issue you describe. As you are all wired up with your
patch code I think it logically makes sense for you to easily make the change,
test and submit a revised working patch to facilitate integration by the
Stripes development team. Having someone else run with this will quite likely
eliminate it from 1.5.4... .
> Add support ala Struts to generate HTML or XHTML compliant close tags
> ---------------------------------------------------------------------
>
> Key: STS-751
> URL: http://www.stripesframework.org/jira/browse/STS-751
> Project: Stripes
> Issue Type: Improvement
> Components: Tag Library
> Affects Versions: Release 1.5
> Environment: No specific OS required; no specific Java version
> required; etc...
> Reporter: Nikolaos
> Priority: Minor
> Attachments: stripes-xhtml-patch.tar.gz, stripes-xhtml-patches.tar.gz
>
>
> HTML and XHTML documents have some key differences.
> For example - if we consider the <input> tag:
> - In HTML, the <input> tag has no end tag e.g. <input name="website.url"
> type="text" size="30">
> - In XHTML, the <input> tag must be properly closed, like this <input />
> e.g. <input name="website.url" type="text" size="30" />
> Stripes 1.5.x however does not have a mechanism to discern whether or not to
> properly close tags or not and as such takes the safer approach which is to
> explicitly close tags as it results in valid XHTML and is not an error for
> HTML but results in a warning when validating HTML documents. Although the
> latter is not a critical issue it does result in needless or unnecessary
> complaints when validating and as such is an annoyance albeit minor.
> Struts since 1.x has solved this issue quite easily by allowing the inclusion
> of the xhtml="true" attribute to mark that closure is required (false
> indicates no closure). In this manner authors of XHTML and HTML documents
> are equally satisfied in not having any errors or extraneous warnings.
> Timothy Stone had reported this issue and classified it as a bug here:
> http://www.stripesframework.org/jira/browse/STS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11931#action_11931
> The issue was rightly closed as "Not a bug" as most of the discussion was
> based on a non-w3c validator which yielded results that considered the
> validation unsuccessful which is not the case with the w3c validator (not to
> mention that it is irrelevant whether or not XHTML is considered dead or we
> should align to HTML 5 - etc...).
> As such this issue report is a re-statement of the above closed issue
> reported as an improvement and setting the stage for patch to be attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
