[ 
http://www.stripesframework.org/jira/browse/STS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11947#action_11947
 ] 

Timothy Stone commented on STS-751:
-----------------------------------

No need to apologize. Thanks for replying.

As a Stripes advocate, the technical lead of a team of HTML developers, and the 
internal standards creator for HTML, JS and CSS coding, I'm not without my 
passion regarding this improvement.

> I still don't get your explanation about the local modification part. 
> Using OSS is OK, but using customized OSS is treated like a security risks or 
> something?
> Sorry for my ignorance, but it doesn't make sense to me.

My rather large, international organization endorses the use of OSS that is 
publicly released, has an active community, and can demonstrate adoption. There 
is a rather large governance organization that would frown on the use of forked 
OSS libraries that were not getting the same vetting process, whatever level 
that vetting process might be by project. Additionally, maintaining release 
compatibility would likely run afoul of the same governance oversight (even 
with the simple text-book use of Vendor branches in CVS, SVN, etc). However, 
when Stripes can be released through Maven, this would make locally forked JAR 
releases easier to manage through a local Maven repository.

Without providing an incredible amount of detail, just know that these policies 
exist and can come bundled with incredible amounts of documentation in large 
organizations.

If anyone should download and review the patch, you'll note that I'm using 
PageContext.PAGE_SCOPE in the patch. I did use PageContext.REQUEST_SCOPE per 
Nikolaos recommendation, but did not want to upload another patch with just 
this change, *until* I got it working.



> Add support ala Struts to generate HTML or XHTML compliant close tags
> ---------------------------------------------------------------------
>
>                 Key: STS-751
>                 URL: http://www.stripesframework.org/jira/browse/STS-751
>             Project: Stripes
>          Issue Type: Improvement
>          Components: Tag Library
>    Affects Versions: Release 1.5
>         Environment: No specific OS required;  no specific Java version 
> required;  etc...
>            Reporter: Nikolaos
>            Priority: Minor
>         Attachments: stripes-xhtml-patch.tar.gz, stripes-xhtml-patches.tar.gz
>
>
> HTML and XHTML documents have some key differences.
> For example - if we consider the <input> tag:
> - In HTML, the <input> tag has no end tag   e.g. <input name="website.url" 
> type="text" size="30">
> - In XHTML, the <input> tag must be properly closed, like this <input />   
> e.g. <input name="website.url" type="text" size="30" />
> Stripes 1.5.x however does not have a mechanism to discern whether or not to 
> properly close tags or not and as such takes the safer approach which is to 
> explicitly close tags as it results in valid XHTML and is not an error for 
> HTML but results in a warning when validating HTML documents.  Although the 
> latter is not a critical issue it does result in needless or unnecessary 
> complaints when validating and as such is an annoyance albeit minor.
> Struts since 1.x has solved this issue quite easily by allowing the inclusion 
> of the xhtml="true" attribute to mark that closure is required (false 
> indicates no closure).  In this manner authors of XHTML and HTML documents 
> are equally satisfied in not having any errors or extraneous warnings.
> Timothy Stone had reported this issue and classified it as a bug here:
> http://www.stripesframework.org/jira/browse/STS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11931#action_11931
> The issue was rightly closed as "Not a bug" as most of the discussion was 
> based on a non-w3c validator which yielded results that considered the 
> validation unsuccessful which is not the case with the w3c validator (not to 
> mention that it is irrelevant whether or not XHTML is considered dead or we 
> should align to HTML 5 - etc...).  
> As such this issue report is a re-statement of the above closed issue 
> reported as an improvement and setting the stage for patch to be attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to