[
http://www.stripesframework.org/jira/browse/STS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11942#action_11942
]
Timothy Stone commented on STS-751:
-----------------------------------
Alright, I need some help... generally, the patch works. However, without using
PageContent.APPLICATION_SCOPE or SESSION_SCOPE, the PAGE and REQUEST scopes are
not providing the nested tags with the attribute set on the layout-definition.
It might help to know how my brain was working in thinking about this
enhancement.
A new attribute would be provided to the LayoutDefinitionTag:
xhtml="(true|false)". The attribute would default to "true" to support current
behavior and the TLD made the attribute optional. For example:
<s:layout-definition xhtml="false">
The LayoutDefinitionTag was chosen for at least two reasons: 1) less frequency
of declaration than in components or render tags and 2) it followed the Struts
<html:html xhtml="false"> pattern of the top most tag.
I did not want to drop right into the use of the Session and Application scopes
for the following reason: a tag attribute placed in the Application scope would
be better defined in the web.xml; Session scope fells tied to a user/client
experience more than a Page or response to a Request.
In looking at the StripesLayoutTag class there are a number of possible other
tools to use that might provide the attribute with scope to components and
renderers, but I'm not precisely sure how to use them right now (give me a few
more days, maybe).
If someone were review the patch, provide a pointer, or point out my glaring
n00b error, it would go a long way in my growth as a Stripes user/developer.
Much thanks.
> Add support ala Struts to generate HTML or XHTML compliant close tags
> ---------------------------------------------------------------------
>
> Key: STS-751
> URL: http://www.stripesframework.org/jira/browse/STS-751
> Project: Stripes
> Issue Type: Improvement
> Components: Tag Library
> Affects Versions: Release 1.5
> Environment: No specific OS required; no specific Java version
> required; etc...
> Reporter: Nikolaos
> Priority: Minor
> Attachments: stripes-xhtml-patch.tar.gz, stripes-xhtml-patches.tar.gz
>
>
> HTML and XHTML documents have some key differences.
> For example - if we consider the <input> tag:
> - In HTML, the <input> tag has no end tag e.g. <input name="website.url"
> type="text" size="30">
> - In XHTML, the <input> tag must be properly closed, like this <input />
> e.g. <input name="website.url" type="text" size="30" />
> Stripes 1.5.x however does not have a mechanism to discern whether or not to
> properly close tags or not and as such takes the safer approach which is to
> explicitly close tags as it results in valid XHTML and is not an error for
> HTML but results in a warning when validating HTML documents. Although the
> latter is not a critical issue it does result in needless or unnecessary
> complaints when validating and as such is an annoyance albeit minor.
> Struts since 1.x has solved this issue quite easily by allowing the inclusion
> of the xhtml="true" attribute to mark that closure is required (false
> indicates no closure). In this manner authors of XHTML and HTML documents
> are equally satisfied in not having any errors or extraneous warnings.
> Timothy Stone had reported this issue and classified it as a bug here:
> http://www.stripesframework.org/jira/browse/STS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11931#action_11931
> The issue was rightly closed as "Not a bug" as most of the discussion was
> based on a non-w3c validator which yielded results that considered the
> validation unsuccessful which is not the case with the w3c validator (not to
> mention that it is irrelevant whether or not XHTML is considered dead or we
> should align to HTML 5 - etc...).
> As such this issue report is a re-statement of the above closed issue
> reported as an improvement and setting the stage for patch to be attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
