[
http://www.stripesframework.org/jira/browse/STS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11946#action_11946
]
Nikolaos commented on STS-751:
------------------------------
>> Unless the changes are extremely small and simple, I would vote -1 for the
>> change.
Iwao - the patch IS extremely small and simple... I mean how much more basic
can you get when it comes to a Tag enhancement than adding a boolean at the top
of something (that defaults to true) and that is read below in a simple if
condition doing ">" or "/>". Please look at the submission code if you are
concerned with de-stabalizing Stripes as I think far more things are likely...
like getting sucked up in a huge sink hole.
The fact that it doesn't work is the problem and the fact that few people have
the cycles to make it work is the issue. Also the patch should not have been
submitted IMO until / unless it was thoroughly tested and working. But those
are side issues to the point of providing this enhancement.
>> I've been reading the series of comments, but tweaking the framework just
>> for avoiding occasional HTML validator warnings seems to be too much to me.
Correction... it is NOT the "occasional" warning... the warning occurs 100% of
the time with HTML 4.01 validation. Sure... the severity of this issue is
debatable as is whether or not to do it... BUT the issue is clear... and also
that is why it is a Minor issue and marked as an Improvement NOT a bug (the
original was marked as a bug which I personally didn't agree with).
If the Stripes development team feels that the code - once it is working - is
not worth integrating for whatever reason that is up to them... but lets get
the facts right.
>> On the other hand, it should be pretty easy and legitimate for you to build
>> HTML 4 compatible version of Stripes locally.
This argument is silly... . If software was built that way I doubt you would
have Stripes or any other OS framework. It's a framework for a reason. Please
go back and re-read the comments. I think you see this as bigger than it is...
Think about a world were every improvement you suggest gets an answer like...
we'll if you want it... fork the code... and the best part: maintain and patch
every next release of the code... and BTW keep doing this with anywhere from 1
today to a dozen or more tomorrow... we just don't build software that way... .
I come from a large project java software development background - forked code
doesn't make it into the Enterprise - period.
>> # And if somebody chose Struts because Stripes has less options, why don't
>> we just let him/her do so? :p
Okay... equally silly argument. Come on... I see the sarcasm... but there is a
saying that says "with every little joke there is a lit bit of truth"... I
really hope your 100% joking on this but others may not think so. In the end,
the original issue was reported as a bug - something I think we all agree was
incorrect - has been more recently reported as a Minor Improvement and assuming
the code can get to a working state, is acceptable to integrate, and is
adequately tested by the community I don't see how anyone could have an issue.
Lastly, I wouldn't knock people going elsewhere and not using Stripes when that
is the #1 CON to using Stripes and trust me that is more detrimental to the
long term viability of the Stripes framework than this fix is... so careful
what you ask for... because you may just get it and not be happy with the
outcome... a dead framework i.e. I don't think ANYONE in the Stripes community
can afford turning anyone away to another framework IMO....
> Add support ala Struts to generate HTML or XHTML compliant close tags
> ---------------------------------------------------------------------
>
> Key: STS-751
> URL: http://www.stripesframework.org/jira/browse/STS-751
> Project: Stripes
> Issue Type: Improvement
> Components: Tag Library
> Affects Versions: Release 1.5
> Environment: No specific OS required; no specific Java version
> required; etc...
> Reporter: Nikolaos
> Priority: Minor
> Attachments: stripes-xhtml-patch.tar.gz, stripes-xhtml-patches.tar.gz
>
>
> HTML and XHTML documents have some key differences.
> For example - if we consider the <input> tag:
> - In HTML, the <input> tag has no end tag e.g. <input name="website.url"
> type="text" size="30">
> - In XHTML, the <input> tag must be properly closed, like this <input />
> e.g. <input name="website.url" type="text" size="30" />
> Stripes 1.5.x however does not have a mechanism to discern whether or not to
> properly close tags or not and as such takes the safer approach which is to
> explicitly close tags as it results in valid XHTML and is not an error for
> HTML but results in a warning when validating HTML documents. Although the
> latter is not a critical issue it does result in needless or unnecessary
> complaints when validating and as such is an annoyance albeit minor.
> Struts since 1.x has solved this issue quite easily by allowing the inclusion
> of the xhtml="true" attribute to mark that closure is required (false
> indicates no closure). In this manner authors of XHTML and HTML documents
> are equally satisfied in not having any errors or extraneous warnings.
> Timothy Stone had reported this issue and classified it as a bug here:
> http://www.stripesframework.org/jira/browse/STS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11931#action_11931
> The issue was rightly closed as "Not a bug" as most of the discussion was
> based on a non-w3c validator which yielded results that considered the
> validation unsuccessful which is not the case with the w3c validator (not to
> mention that it is irrelevant whether or not XHTML is considered dead or we
> should align to HTML 5 - etc...).
> As such this issue report is a re-statement of the above closed issue
> reported as an improvement and setting the stage for patch to be attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
