--- Steve Raeburn <[EMAIL PROTECTED]> wrote: > I'd like to add two new actions to org.apache.struts.actions that I find > particularly useful. > > 1. SuccessAction - A simple action that forwards control to an > ActionFoward > named "success". > > This is a very simple action, but I find it exceptionally useful, > particularly in the early stages of development when it can act as a > placeholder for as-yet undeveloped actions. > > public ActionForward execute( > ActionMapping mapping, > ActionForm form, > HttpServletRequest request, > HttpServletResponse response) > throws Exception { > > ActionForward forward = mapping.findForward("success"); > if (forward == null) { > String message = > messages.getMessage("success.required", mapping.getPath()); > log.error(message); > throw new ServletException(message); > } > return forward; > }
I'm not a big fan of Struts hardcoding things like forward names or message keys in the standard distro. We shouldn't be dictating that type of thing. Why can't you use a ForwardAction to acheive this type of functionality? > > 2. ParameterDispatchAction - A DispatchAction that selects a handler > method > using the value of the ActionMapping parameter. > > This is as per the suggestion by Anthony Kay via Bugzilla > <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17117>, except I > prefer > the name ParameterDispatchAction to his suggestion of > ConfigDispatchAction > as I think it's more descriptive of what the class actually does. Other > than > the name change, I've just tidied up the Javadoc and changed the > 'unspecified' method to throw an Exception (as in DispatchAction) rather > than return an Http error code. I have no problems with this one. I don't currently use DispatchAction but is there a way the proposed behavior could be included with that class instead of a new one? David > > If no one has any problems with adding these two, I'll put them in > tomorrow. > > > Steve > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]