--- Niall Pemberton <[EMAIL PROTECTED]> wrote: > I submitted a PATCH in May 2001, but it wasn't applied. > > http://www.mail-archive.com/[EMAIL PROTECTED]/msg01450.html > http://issues.apache.org/bugzilla/show_bug.cgi?id=1683
That bug is marked fixed but there are no patches attached to it. This is a perfect example of why we ask patches to not be sent via email and prefer them to be attached to the bugzilla ticket. > > I haven't looked at them for a while but the issue was with the big > chunks > of code in the doStartTag()/doEndTag() - refactoring attributes out of > those > makes life much easier and I think was a good idea. > > I would do it again for the current Struts except that I don't want to > botther putting the effort in for it to be ignored a second time. I'm willing to work with you on this if you have the time to test and submit patches. Let's start with one tag and discuss the needed changes on struts-dev before coding anything. When we decide on the right changes to make we can open a bugzilla ticket to track things. My main area of interest is in the html taglib because it offers functionality not provided by the JSTL; however, if other tags need refactoring I'm willing to work on those as well. Does this sound reasonable? David > > Niall > > ----- Original Message ----- > From: "David Graham" <[EMAIL PROTECTED]> > To: "Struts Developers List" <[EMAIL PROTECTED]> > Sent: Thursday, September 25, 2003 9:39 PM > Subject: RE: Editable Fields V/S Static Text > > > > Whenever tag extendability enhancements are discussed, we always hear > > complaints from a vocal minority but no tested working patches show > up. I > > haven't heard any good suggestions that would make the tags easier to > > subclass. If the current factoring isn't good enough, provide patches > for > > something better. > > > > David > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > __________________________________ Do you Yahoo!? The New Yahoo! Shopping - with improved product search http://shopping.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
