On 18 Sep 2011, at 03:29, manuel quiñones wrote: > 2011/9/17 Gary Martin <[email protected]>: >> On 17 Sep 2011, at 06:21, Gonzalo Odiard wrote: >> >>> >>> On Fri, Sep 16, 2011 at 11:42 PM, Gary Martin <[email protected]> >>> wrote: >>> Hi Gonzalo, >>> >>> On 16 Sep 2011, at 02:14, Gonzalo Odiard wrote: >>> >>>> I have uploaded a new version of Memorize [1], >>>> with the changes we discussed in irc today, and a few more fixes. >>>> * Auto save of modified games (but no demos) >>>> * Alerts with new texts. >>>> * Change to equal tiles mode fixes. >>>> * Remove hippo dependency. >>>> Any feedback is welcomed >>> >>> Just managed to take a quick look tonight. On an XO the Stop button falls >>> off the toolbar into the overflow menu. Couple of suggestions to rectify it: >>> >>> - Use separator.set_size_request(0, -1) on the invisible separator that is >>> used to push the Stop button to the right, otherwise it takes up some space >>> and can trigger an overflow. >>> >>> - We can drop the separator between 'Restart Game' and the 'Equal Pairs' >>> icon >>> >>> Thanks! Just in time to the release :) >>> I needed remove the intermediate separator and do the set_size_request, but >>> we will have problems with other languages. >>> The spanish translation of 'Load demo games' is 'Cargar juegos de >>> demostracion' and two buttons are out :( >> >> Damn :-( :-( Keep getting caught out by toolbar text translations. >> >> Manuel: Pester/remind me about adding a new HIG recommendation to avoid >> using text in the toolbars unless there is plenty of free space available, >> this one has caught us several times already. > > Yes Gary, I was also thinking that we should add this advice in Sugar's HIG > >> >>> May be we can use a collection button (with a box, like in abacus or turtle >>> art? >> >> Yes, I guess is the option we now have. We will need an icon, or icons for >> the current 3 demo games. We could use a single icon like TamTam Synth's >> sound presets (a memorise like document would do), or try for a custom icon >> for each game like Walter tried for Abacus – if there are good candidates >> (addition, letters, sounds). > > As we are already late, I can try to do this change before monday > meeting. Gonzalo, if you updated the patches, please send them to me.
As discussed in todays design meeting, here is the collection style icon for a menu palette to replace the current memorize combo box for access to demo games (the resolves the issue with translated text overflowing the toolbar):
<<inline: memorize-collection.png>>
<<inline: memorize-collection.svg>>
Regards, --Gary >> Raises an interesting issue regarding disabling of a primary toolbar icon >> with a secondary palette, or do we just disable the demo game buttons on the >> secondary palette. Need to watch for corner cases, e.g if the demo game >> secondary toolbar is already open when a user clicks customize. Perhaps we >> do not need to disable the demo game selection now that we have the warning >> message (i.e. allow users to load in different demo games so they can >> see/edit the cards directly in customise mode)? >> >>> Some suggested string changes: >>> >>> - 'Click for non equal pairs' should be 'Set non equal pairs' >>> >>> - 'Click for equal pairs' should be 'Set equal pairs' >>> >>> - 'Click for ungrouped game' should be 'Set ungrouped game' >>> >>> - 'Click for grouped game' should be 'Set grouped game' >>> >>> >>> Perfect, applied. >>> >>> Other than that it's looking good! :) >>> >>> I will try to publish one new version tomorrow. >>> May be the Monday we can discuss the demos combo substitution in the Design >>> chat. >> >> Sure. Do we still have time before we need to make an official release? >> >> Regards, >> --Gary >> >>> >>> Gonzalo >>> >> > > -- > .. manuq ..
_______________________________________________ Sugar-devel mailing list [email protected] http://lists.sugarlabs.org/listinfo/sugar-devel
