On Mon, Oct 16, 2006 at 09:45:03PM +0200, Rafael J. Wysocki wrote: > On Monday, 16 October 2006 21:21, Stefan Seyfried wrote: > > On Mon, Oct 16, 2006 at 09:06:07PM +0200, R. J. Wysocki wrote: > > > On Monday, 16 October 2006 20:55, Stefan Seyfried wrote: > > > > Hi, > > > > > > > > If nobody objects, i'd send this to LKML: > > > > Maybe somebody with a recent -mm kernel can test if it still applies > > > > there :-) > > > > > > I have a very similar patch, but with two differences, that applies to -mm > > > and has been tested (on one box): > > > > ok, even better. My patch is still compiling, but i have no machine here > > where > > i can test its effectiveness (on a thinkpad, you see the moon blink after > > pm_ops->prepare(), but i only get to one tomorrow ;-) > > When you can, please test my patch and I'll post it to LKML if it works.
I did not forget this one, but will test later today. > Do you mean platform_finish is also needed when platform_prepare fails? Probably not. The other sleep modes do (in main.c:84): if (pm_ops->prepare) { if ((error = pm_ops->prepare(state))) goto Thaw; } suspend_console(); if ((error = device_suspend(PMSG_SUSPEND))) { printk(KERN_ERR "Some devices failed to suspend\n"); goto Finish; } return 0; Finish: if (pm_ops->finish) pm_ops->finish(state); Thaw: thaw_processes(); Enable_cpu: enable_nonboot_cpus(); pm_restore_console(); return error; So this looks ok. No, i do not want to look at ACPI spec :-) -- Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel