Hi! > > >> Why exacly was sys_sync removed from prepare_processes? > > > > > > Because it was moved to freeze_processes(). > > > > > >> My last power failure during suspend-to-disk caused a journal replay > > >> which took a few minutes on reboot. > > > > > > AFAICT, sys_sync doesn't prevent journal replies from happening on > > > failure. > > > It only causes data to be written to the storage, metadata are different > > > story. > > > > Ah, didn't know that. Is there any generic metadata sync call which > > could be called on suspend? > > Well, in principle we can call freeze_bdev() for each mounted filesystem > during the suspend, but first Pavel is against it and second thaw_bdev() > misbehaves in our error paths (I've got scheduling while atomic messages > out of it for several times).
sync should be enough to preserve data. Journal replay is quite harmless... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel