I suppose it would be nice if someone actually reviewed the code, to see if it looks good. Who else in SymPy knows what is going on in GA?
Aaron Meurer On Fri, Apr 12, 2013 at 4:40 PM, Alan Bromborsky <abro...@verizon.net>wrote: > On 04/12/2013 02:01 PM, Alan Bromborsky wrote: > > On 04/12/2013 12:59 PM, Aaron Meurer wrote: > > Did you intend to send a response to a GitHub comment to the mailing list? > > Regarding your question, I think Sphninx is just messed up with > sympy-bot. What version of Sphinx do you have (it is printed in the build > somewhere)? Anyway, as long as it builds locally (with a make clean > first), it is fine. > > Aaron Meurer > > > On Fri, Apr 12, 2013 at 10:21 AM, Alan Bromborsky <abro...@verizon.net>wrote: > >> On 04/12/2013 04:27 AM, Julien Rioux wrote: >> >> I never got custom macros to work, therefore I removed them at >> b44e253<https://github.com/sympy/sympy/commit/b44e2537146223c8829cf94446c136e46bc30a06>. >> If you can get the docs to compile with them, then that's fine, but >> otherwise you will have to substitute your custom macros for standard >> latex, as we want to keep the docs compilable. IMHO it will make your >> source much more readable anyway (you might be used to what e.g. \lbrkis a >> short-hand for, but nobody else is). >> >> >> Reply to this email directly or view it on >> GitHub<https://github.com/sympy/sympy/pull/1937#issuecomment-16281340> >> . >> >> I removed all latex macros and fixed problem with tabels. Both html and >> latex now build locally without problems. When I run - >> >> ./sympy-bot review 1937 -D --reference /home/brombo/MathPhysics/sympy >> >> I get the error - >> >> /tmp/sympy-bot-tmpl6atud/sympy/doc/src/modules/integrals/integrals.rst:106: >> WARNING: autodoc can't import/find method 'sympy.integrals.manualintegrate', >> it reported error: "manualintegrate", please check your spelling and sys.path >> >> make: *** [html] Error 1 >> >> >> Which is in the documentation for a module that I have nothing to do >> with. Any suggestions would be welcome. Could I have messed up conf.py? >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sympy+unsubscr...@googlegroups.com. >> To post to this group, send email to sympy@googlegroups.com. >> Visit this group at http://groups.google.com/group/sympy?hl=en-US. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To post to this group, send email to sympy@googlegroups.com. > Visit this group at http://groups.google.com/group/sympy?hl=en-US. > For more options, visit https://groups.google.com/groups/opt_out. > > > > The only problem left in latex build is cross referencing to equations. > Line 153 in ga.rst defines label eq1. This label is referred to in lines > 176 and 177 of ga.rst. > Line 457 in ga.rst defines label eq3. This label is referred to in line > 475. This works for the html build. In the latex build (make all in latex > directory) these > cross references are undefined. Any suggestions? > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To post to this group, send email to sympy@googlegroups.com. > Visit this group at http://groups.google.com/group/sympy?hl=en-US. > For more options, visit https://groups.google.com/groups/opt_out. > > > > I fixed references by copying changes that had been made to my old docs to > make latex build work. Both html and latex doc builds now work locally > without errors. I have pushed doc changes to GA_rewrite on github. What > next? > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To post to this group, send email to sympy@googlegroups.com. > Visit this group at http://groups.google.com/group/sympy?hl=en-US. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy?hl=en-US. For more options, visit https://groups.google.com/groups/opt_out.
