On Tue, Mar 18, 2014 at 5:09 PM, Sushant Hiray <hiraysush...@gmail.com> wrote: > Hi, > >> >> I would simply translate the `t.py` implementation to C++ in CSymPy. >> I don't think it's hard. Just implement the "TrigFunction" class which >> implements the gist of the algorithm and then implement the actual >> Sin, Cos, Tan classes as in `t.py`. >> >> There will probably be some corner cases, so it's good to spend some time >> on this and get this right. >> > > True. I went through the code and I guess the code is not that hard. > So I shaped my timeline accordingly. > >> >> We'll also probably want to extend it to functions like sec(), but getting >> sin/cos/tan right is more important. >> > > Yeah, sure! That is the aim. Well we could atleast use them as the > reciprocal > of `sin`,`cos`,`tan` just for the sake of completeness. > >> >> > >> > Also adding python wrappers should be a decent plus. >> > > > > I do not have any experience regarding this. Though surely we can try this > out. I did give it a place in the timeline :) > >> >> >> You should also put there a schedule of what things you want to get >> >> done each week. >> > > > > I have written a rough timeline. There can still be some more changes before > it gets finalized. Do give me some inputs regarding how it looks. > Too optimistic maybe?
I looked at the timeline, I don't think it's too optimistic. Obviously things go a little slower in C++ than in Python, but it's really not that difficult. I think the trig stuff can be done sooner, I don't expect any major issues. The Complex stuff might trigger some issues that we might to tackle, we'll see. Otherwise looks good to me. Ondrej > >> >> >> Thanks! I left some minor comments on the PR. >> > Thanks about that! I've updated according to Sergey's suggestions as well. > I guess there was some issue with Travis builds. I saw it on gitter. So I > suspect > it'll take some time before the tests are scheduled back on track again. > > Anyways looking forward to the inputs on the timeline. > > If I manage some time, I'll push in taylor term for cosec. > Rest have been added. > > Regards, > Sushant Hiray >> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "sympy" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/sympy/V1zGL4YM_kE/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> sympy+unsubscr...@googlegroups.com. >> >> To post to this group, send email to sympy@googlegroups.com. >> Visit this group at http://groups.google.com/group/sympy. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sympy/CADDwiVA%3DmxkB5xp-Q%3D-baF3eAcD-1YrNZ7P1tDf%2B0H7uYCinJQ%40mail.gmail.com. >> >> For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To post to this group, send email to sympy@googlegroups.com. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/CAN2RUgrfCOwdGwUqQbOsGhAFCDY1cXCM%2BaHjusQKJrJ-5p%3Ddig%40mail.gmail.com. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADDwiVCXRqYLhHdf2FqFNodhpsGRuFjGnUshOPNsBaiesF0%3DpA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
