> On 2009-04-11 20:34:30.731550, Paul Wise wrote: > > /synfig-core/trunk/src/synfig/valuenode_pow.cpp, line 58 > > <http://patches.synfig.org/r/18/diff/2/?file=111#file111line58> > > > > Shouldn't you use INFINITY from math.h instead?
Ok, I tried this out. Using INFINITY appears to work decently in some cases. For example, a z-depth of -INFINITY is above all other layers. However, there are problems. For example, INF-INF yields NaN, which is not a good value to have... No errors messages are thrown, but the entire layer fails to render. If we want to retain the current error-free behavior, I suggest defining INFINITE and EPSILON as 10^6/10^-6 in valuenode.h, and using these definitions. P.S. I noticed that a zoom value greater than 11 causes the canvas to not render. - nikitakit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/18/#review39 ----------------------------------------------------------- On 2009-03-31 22:02:46.769631, nikitakit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/18/ > ----------------------------------------------------------- > > (Updated 2009-03-31 22:02:46.769631) > > > Review request for Synfig. > > > Summary > ------- > > New ValueNode type: Power (valuenode_pow): > Attributes: base, power, epsilon, infinite > Function: returns base^power > Fractional and negative powers are supported, so this ValueNode type can also > do square roots, reciprocals, etc. > > Note that I implemented this type in error-free mode. That is, the node gives > an output even if the operation is undefined. (This appears to be the > accepted standard.) The special definitions are: > 1. 0^-x is "+/- infinite" > 2. If a negative base is raised to a noninteger power, the power is rounded > (typecast) to an integer > > > Diffs > ----- > > /synfig-core/trunk/src/synfig/Makefile.am 2355 > /synfig-core/trunk/src/synfig/valuenode.cpp 2355 > /synfig-core/trunk/src/synfig/valuenode_pow.h PRE-CREATION > /synfig-core/trunk/src/synfig/valuenode_pow.cpp PRE-CREATION > > Diff: http://patches.synfig.org/r/18/diff > > > Testing > ------- > > Compiles & runs. All features work as planned, but the way undefined outputs > are treated may need to be revised. > > > Thanks, > > nikitakit > > ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
