> On 2009-04-11 20:34:30.731550, Paul Wise wrote: > > /synfig-core/trunk/src/synfig/valuenode_pow.cpp, lines 63-64 > > <http://patches.synfig.org/r/18/diff/2/?file=111#file111line63> > > > > I don't think these need to be exported to the user interface or the > > .sif file? > > wrote: > That certainly makes sense. However, a few existing valuenodes (such as > reciprocal and logarithm) use infinity/epsilon. I copied the code relating to > these two values from another file. If we don't use infinite/epsilon here, > then the other valuenodes should be modified for consistency. > > wrote: > Agreed, that should be a different patch though I think.
If someone has a file with animated epsilon and/or infinity from the previous versions (i.e. reciprocal and logarithm) it would become impossible to open those old files if we unexport them in a new synfig version. I think they don't hurt staying there and leave an opportunity to the user to decide what's "infinite" and what's "zero". > On 2009-04-11 20:34:30.731550, Paul Wise wrote: > > /synfig-core/trunk/src/synfig/valuenode_pow.cpp, lines 165-166 > > <http://patches.synfig.org/r/18/diff/2/?file=111#file111line165> > > > > What is this for? Why not just define epsilon = 0.00000001; in the > > constructor? This is to avoid the user modify epsilon under a minimum value. - Carlos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/18/#review39 ----------------------------------------------------------- On 2009-03-31 22:02:46.769631, nikitakit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/18/ > ----------------------------------------------------------- > > (Updated 2009-03-31 22:02:46.769631) > > > Review request for Synfig. > > > Summary > ------- > > New ValueNode type: Power (valuenode_pow): > Attributes: base, power, epsilon, infinite > Function: returns base^power > Fractional and negative powers are supported, so this ValueNode type can also > do square roots, reciprocals, etc. > > Note that I implemented this type in error-free mode. That is, the node gives > an output even if the operation is undefined. (This appears to be the > accepted standard.) The special definitions are: > 1. 0^-x is "+/- infinite" > 2. If a negative base is raised to a noninteger power, the power is rounded > (typecast) to an integer > > > Diffs > ----- > > /synfig-core/trunk/src/synfig/Makefile.am 2355 > /synfig-core/trunk/src/synfig/valuenode.cpp 2355 > /synfig-core/trunk/src/synfig/valuenode_pow.h PRE-CREATION > /synfig-core/trunk/src/synfig/valuenode_pow.cpp PRE-CREATION > > Diff: http://patches.synfig.org/r/18/diff > > > Testing > ------- > > Compiles & runs. All features work as planned, but the way undefined outputs > are treated may need to be revised. > > > Thanks, > > nikitakit > > ------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p _______________________________________________ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
