> On 2009-04-11 20:34:30.731550, Paul Wise wrote: > > /synfig-core/trunk/src/synfig/valuenode.cpp, line 185 > > <http://patches.synfig.org/r/18/diff/2/?file=109#file109line185> > > > > The version is wrong since 0.61.09 is already released, the next > > release should be 0.61.10. The comment isn't necessary either and should be > > the same as the comments above it, the person who commits should predict > > the SVN commit revision and add the right one to the comment
My bad on the version number. And yes, whoever commits this (not me since I don't have access) should modify the comment. > On 2009-04-11 20:34:30.731550, Paul Wise wrote: > > /synfig-core/trunk/src/synfig/valuenode_pow.h, line 8 > > <http://patches.synfig.org/r/18/diff/2/?file=110#file110line8> > > > > Why the extra copyright holders? I copy-pasted the code from another valuenode, so I kept the original copyright holders for it. > On 2009-04-11 20:34:30.731550, Paul Wise wrote: > > /synfig-core/trunk/src/synfig/valuenode_pow.cpp, lines 63-64 > > <http://patches.synfig.org/r/18/diff/2/?file=111#file111line63> > > > > I don't think these need to be exported to the user interface or the > > .sif file? That certainly makes sense. However, a few existing valuenodes (such as reciprocal and logarithm) use infinity/epsilon. I copied the code relating to these two values from another file. If we don't use infinite/epsilon here, then the other valuenodes should be modified for consistency. - nikitakit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/18/#review39 ----------------------------------------------------------- On 2009-03-31 22:02:46.769631, nikitakit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/18/ > ----------------------------------------------------------- > > (Updated 2009-03-31 22:02:46.769631) > > > Review request for Synfig. > > > Summary > ------- > > New ValueNode type: Power (valuenode_pow): > Attributes: base, power, epsilon, infinite > Function: returns base^power > Fractional and negative powers are supported, so this ValueNode type can also > do square roots, reciprocals, etc. > > Note that I implemented this type in error-free mode. That is, the node gives > an output even if the operation is undefined. (This appears to be the > accepted standard.) The special definitions are: > 1. 0^-x is "+/- infinite" > 2. If a negative base is raised to a noninteger power, the power is rounded > (typecast) to an integer > > > Diffs > ----- > > /synfig-core/trunk/src/synfig/Makefile.am 2355 > /synfig-core/trunk/src/synfig/valuenode.cpp 2355 > /synfig-core/trunk/src/synfig/valuenode_pow.h PRE-CREATION > /synfig-core/trunk/src/synfig/valuenode_pow.cpp PRE-CREATION > > Diff: http://patches.synfig.org/r/18/diff > > > Testing > ------- > > Compiles & runs. All features work as planned, but the way undefined outputs > are treated may need to be revised. > > > Thanks, > > nikitakit > > ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
