----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/18/#review47 -----------------------------------------------------------
Ship it! Makefile.am did not patch properly because the file was changed later. Anyway I've modified manually based on latest revision. Curiously I had problems if I run 'make -j 4' it seems that there is not a good coordination between the different threads when doing make. Then I ran just 'make' and it was all fine. I've tested the functionality and it seems to work. Also I've modified the valuenode.cpp file to match the next commit. I'll ship it. Nikitakit, please update the wiki accordingly to the new valuenode. Thanks. - Carlos On 2009-03-31 22:02:46.769631, nikitakit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/18/ > ----------------------------------------------------------- > > (Updated 2009-03-31 22:02:46.769631) > > > Review request for Synfig. > > > Summary > ------- > > New ValueNode type: Power (valuenode_pow): > Attributes: base, power, epsilon, infinite > Function: returns base^power > Fractional and negative powers are supported, so this ValueNode type can also > do square roots, reciprocals, etc. > > Note that I implemented this type in error-free mode. That is, the node gives > an output even if the operation is undefined. (This appears to be the > accepted standard.) The special definitions are: > 1. 0^-x is "+/- infinite" > 2. If a negative base is raised to a noninteger power, the power is rounded > (typecast) to an integer > > > Diffs > ----- > > /synfig-core/trunk/src/synfig/Makefile.am 2355 > /synfig-core/trunk/src/synfig/valuenode.cpp 2355 > /synfig-core/trunk/src/synfig/valuenode_pow.h PRE-CREATION > /synfig-core/trunk/src/synfig/valuenode_pow.cpp PRE-CREATION > > Diff: http://patches.synfig.org/r/18/diff > > > Testing > ------- > > Compiles & runs. All features work as planned, but the way undefined outputs > are treated may need to be revised. > > > Thanks, > > nikitakit > > ------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
