[
https://issues.apache.org/jira/browse/THRIFT-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918728#action_12918728
]
Steven Knight commented on THRIFT-591:
--------------------------------------
Roger--
My fault for bad wording.
When I said "this patch," I really meant to say, "The work that Rush Manbert
did on this JIRA issue"--that is, Visual Studio C++ support.
As I indicated in the previous comment, what I added is *not* in a finished or
tested state, as I only got part way through that process before being told to
work on other things. I supplied the patch here in the hope that it would help
Richard get a head start, since he indicated he was about to start work on
updating Rush' original patch for Thrift 0.4.0. I did not mean to imply I
thought the patch was ready to apply as-is to the code base.
Sorry for the confusion,
> Make the C++ runtime library be compatible with Windows and Visual Studio
> -------------------------------------------------------------------------
>
> Key: THRIFT-591
> URL: https://issues.apache.org/jira/browse/THRIFT-591
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Library
> Environment: Windows XP and above, Visual Studio 2005 and above
> Reporter: Rush Manbert
> Attachments: MsvcPatchSupportScripts.zip,
> MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch,
> THRIFT-591_MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch_error.log,
> thrift-818530-patched.zip, ThriftMsvcPatchForSvnRev818530.txt.zip,
> thriftWindowsRev818530BugFix.zip
>
>
> Modify the C++ runtime library to be compatible with Windows and able to be
> built by Visual Studio.
> The work has been done and a patch is available. I will attach it soon.
> Note that this issue and the attached patch supercedes the patches that I
> wrongly attached to JIRA 311. That issue is about making the C++ library
> support async client/server interaction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
