[
https://issues.apache.org/jira/browse/THRIFT-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922353#action_12922353
]
Bruce Lowekamp commented on THRIFT-591:
---------------------------------------
I think an asio implementation should live as a parallel alternative, even if
imported. Bridging between asio and non-asio (in either direction) is hard to
do without a context switch unless the code is really designed for it, and so
not really a great option.
But it also wouldn't be the first example of a language having multiple
transports.
Continuous integration being fully deployed will also make such an option much
safer to import.
---------------------
(I accidentally sent this reply via email earlier, so reposting so everything
is in one place)
(as the author of Rush's quote)
I remember we looked at the patch, though I didn't do it at the time and don't
remember if ours was similar. We were trying to add out-of-order in addition
to asynchronous, so I think it's likely significantly different.
Regardless, I think an asio version should be written on top of the recent
async/restructure that fb contributed. I don't think it would be that much
work, but don't know if I'll get time soon.
Bruce
> Make the C++ runtime library be compatible with Windows and Visual Studio
> -------------------------------------------------------------------------
>
> Key: THRIFT-591
> URL: https://issues.apache.org/jira/browse/THRIFT-591
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Library
> Environment: Windows XP and above, Visual Studio 2005 and above
> Reporter: Rush Manbert
> Attachments: MsvcPatchSupportScripts.zip,
> MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch,
> THRIFT-591_MSVCSupportUpdatedButUntestedForThrift-0.4.0.patch_error.log,
> thrift-818530-patched.zip, ThriftMsvcPatchForSvnRev818530.txt.zip,
> thriftWindowsRev818530BugFix.zip
>
>
> Modify the C++ runtime library to be compatible with Windows and able to be
> built by Visual Studio.
> The work has been done and a patch is available. I will attach it soon.
> Note that this issue and the attached patch supercedes the patches that I
> wrongly attached to JIRA 311. That issue is about making the C++ library
> support async client/server interaction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
