On Wed, 2016-11-09 at 23:09 +0000, Thomas Habets wrote: > On 9 November 2016 at 21:22, Hon Ching(Vicky) Lo > <[email protected]> wrote: > > Patches for TrouSers that support OpenSSL1.1 are welcomed! However, > > 1) they need to be tested. > > Is there a testing procedure, or are you just talking about building > it and seeing that it seems to be working? > > What could I do to help?
Sorry, I missed telling you the testing. Normally, I would test it by running the TrouSers test suites to make sure nothing breaks. (i.e. not just making sure that it builds) Regards, Vicky > > > 2) they need to be backward-compatible. > > Since your patch doesn't work with OpenSSL1.0, would it be possible that > > if you "#ifdef" your code? > > It looks like the RedHat patch attached to > https://bugzilla.redhat.com/show_bug.cgi?id=1388518 already supports > both OpenSSL 1.0 and 1.1. > > I say this because it conditionally implements this function for older > OpenSSL: > > [...] > +#if OPENSSL_VERSION_NUMBER < 0x10100001L > +static int > +RSA_set0_key(RSA *r, BIGNUM *n, BIGNUM *e, BIGNUM *d) > +{ > [...] > > Is this not working for you? > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ TrouSerS-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/trousers-tech
