on 5/30/2000 3:40 PM, Rafal Krzewski at [EMAIL PROTECTED] wrote:
>> It should do the classpath first AND what you suggest second.
>
> Please, give me your reasons for this.
> My thinking goes like that: If I explicitly specify a location of
> the config file, I don't want WebMacro to dig through my
> classpath and grab some random one, silently overriding my
> input.
> (not that I have a habit of leaving config files lying around,
> if this happens to someone, it can be really annoying)
My reasoning was to look for existing methodology first and then new
methodology second. Your reasoning makes sense though so go for it.
> I was reding their list and found related messages, just as you
> said. There was a lengthy thread "Making templates relocatable"
> running in February/March, but I haven't yet discovered to what conclusions
> they've came to. I need to read a bit more, to make sure I wont duplicate
> their work.
make sure you don't duplicate stuff.
> I know that we are using a CVS snapshot made about three weeks ago.
> Unfortunately shimari.com's CVSWEB is not working, and I wasn't able
> to find any information about anonymous access to the CVS.
> I'd rather start hacking on the sources instead of chasing them around,
> so I'd appreciate some pointers....
here is the info...
> You can access the WebMacro CVS archive anonymously again. If you are
> doing any development based on core WebMacro classes (as opposed to just
> writing servlets) you should probably track the CVS archive.
>
> Here are the details:
>
> CVSROOT=:pserver:[EMAIL PROTECTED]:/wm
> cvslogin
> password: mackerel
>
> cvs checkout webmacro
>
> This provides you with read-only access to the CVS tree.
>
> Justin Wells <[EMAIL PROTECTED]>
if that doesn't work, bug justin.
> One more thing - if we consider giving the location of WebMarco properties
> to Turbine servlet, shouldn't we provide the parametrs as
> Turbine.properites and WebMacro properties respectively?
>
> diff -u -r1.58 Turbine.java
> --- Turbine.java 2000/05/27 23:42:44 1.58
> +++ Turbine.java 2000/05/30 21:45:14
> @@ -105,6 +105,9 @@
>
> /** this is the string that is looked for when getInitParameter is called */
> private static final String INIT_PROPS_KEY = "properties";
> +
> + /** if more than one 'property' parameter is needed, full name may be
> used */
> + private static final String INIT_PROPS_KEY_ALT = "Turbine.properties";
It would be TurbineResources.properties
> /**
> * This init method will load the default resources from a properties file.
> @@ -114,6 +117,10 @@
> super.init(config);
>
> String props = getInitParameter(INIT_PROPS_KEY);
> + if( props == null )
> + {
> + props = getInitParameter(INIT_PROPS_KEY_ALT);
> + }
I'm still not sure what you are getting at here. would you want the name to
look for be "Turbine.properties" because you have "WebMacro.properties"???
We had some strange problem in the past with having a servlet named Turbine
and Turbine.properties as well. I forget the entire nature of the problem,
but we renamed Turbine.properties to TurbineResources.properties a long time
ago and I don't see a reason to go back now.
So -1 on the patch.
-jon
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
