Thanks for the patch Andy. I do have a few comments that I hope you
can address :-)
Would it be possible to break this down a little - there are changes
in there to the startup code and to the Spring container - is it
possible to separate those so that there is less to tackle in one go?
For example, are the startup changes really coupled to renaming the
SpringSCA XSD?
Some of the changes seem cosmetic (e.g. JavaDoc changes) and these
really are easier to review if kept separate.
Also some of the changes don't seem to fit our coding style
guidelines. I know we're often lax about that but I felt I should
mention it as we're actively trying to improve. You can check this
fairly easily using the "sourcecheck" profile in Maven ("mvn -o -
Psourcecheck").
On a legal front, please can you make sure new files have the correct
header block on them (the new one without a (c) statement). Apache
also prefers that files do not contain @author tags we are following
that guideline.
We've tried real hard to avoid a dependency on a particular logging
framework, clogging in particular due to the conflicts that occur
between different projects (for example, you're including 1.1 but
some of our other dependencies are using older versions).
Getting to the technical stuff, the big question I have is about
passing in a Map of properties. This seems to go against the IoC
principles of SCA, Tuscany and Spring. Did you consider extending
RuntimeInfo e.g. as SpringRuntimeInfo, adding in something like
getApplicationContext() ? Or perhaps better, adding the
ApplicationContext as a component in the runtime that could be
directly used as a dependency?
Once again, thanks for the patch. If you do get a chance to look at a
couple of these things I'll be online tomorrow and able to help get
the changes in.
--
Jeremy
On Sep 6, 2006, at 11:28 AM, Andy Piper (JIRA) wrote:
[ http://issues.apache.org/jira/browse/TUSCANY-699?page=all ]
Andy Piper updated TUSCANY-699:
-------------------------------
Attachment: springlaunch.patch
Allow bootstrap of tuscanny from spring web apps / struts apps etc
------------------------------------------------------------------
Key: TUSCANY-699
URL: http://issues.apache.org/jira/browse/TUSCANY-699
Project: Tuscany
Issue Type: Improvement
Components: Java SCA Core
Affects Versions: Java-M2
Reporter: Andy Piper
Attachments: springlaunch.patch
Spring provides a wealth of web app integration components. To
reimplement these in Tuscany would be prohibitive, instead we need
to allow Spring to bootstrap Tuscany and use its standard
extension mechanisms.
I have a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://issues.apache.org/jira/secure/
Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/
software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
