Raymond Feng <[EMAIL PROTECTED]> writes:
Hi,
Please review and vote on the 1.0.1-incubating release artifacts of
Tuscany
SCA for Java.
The RC4 contains a few fixes to issues discovered in RC3. Thank you for
reporting and fixing the issues promptly.
SVN Tag:
http://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/1.0.1-RC4/
Stage maven repo: http://people.apache.org/~rfeng/tuscany/maven/
RAT report:
http://people.apache.org/~rfeng/tuscany/1.0.1-RC4/1.0.1-RC4.rat.txt
Distros (zip/gz/asc/md5) :
http://people.apache.org/~rfeng/tuscany/1.0.1-RC4/
Thanks,
Raymond
PS: I posted this message on Friday and it was only sent to myself
First of all, thanks Raymond for doing the builds for the next release.
I've not had time to run all the samples but I have tried some of the
samples
using the binary distribution on Linux for the testing.
Generally, the release looks good. I would give it a +0.5 as it has some
minor
issues but possibly not enough to prevent it's release.
My review comments are below:
Medium - perhaps needs investigation?
=====================================
Can't get mvn to build sample projects
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This might simply be because the artefacts are not published to the Maven
repository yet.
Cannot build with Maven. When I run the "mvn" command, I get the following
output:
[INFO] Scanning for projects...
Downloading:
http://repo1.maven.org/maven2/org/apache/tuscany/sca/tuscany-sca/1.
0.1-incubating/tuscany-sca-1.0.1-incubating.pom
[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.
GroupId: org.apache.tuscany.sca
ArtifactId: tuscany-sca
Version: 1.0.1-incubating
Reason: Unable to download the artifact from any repository
org.apache.tuscany.sca:tuscany-sca:pom:1.0.1-incubating
from the specified remote repositories:
central (http://repo1.maven.org/maven2)
[INFO] ------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.reactor.MavenExecutionException: Cannot find parent:
org.apache
.tuscany.sca:tuscany-sca for project:
null:sample-osgi-supplychain:jar:null for
project null:sample-osgi-supplychain:jar:null
at org.apache.maven.DefaultMaven.getProjects(DefaultMaven.java:378)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:290)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:280)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at
org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.project.ProjectBuildingException: Cannot find
parent
: org.apache.tuscany.sca:tuscany-sca for project:
null:sample-osgi-supplychain:j
ar:null for project null:sample-osgi-supplychain:jar:null
at
org.apache.maven.project.DefaultMavenProjectBuilder.assembleLineage(D
efaultMavenProjectBuilder.java:1261)
at
org.apache.maven.project.DefaultMavenProjectBuilder.buildInternal(Def
aultMavenProjectBuilder.java:747)
at
org.apache.maven.project.DefaultMavenProjectBuilder.buildFromSourceFi
leInternal(DefaultMavenProjectBuilder.java:479)
at
org.apache.maven.project.DefaultMavenProjectBuilder.build(DefaultMave
nProjectBuilder.java:200)
at org.apache.maven.DefaultMaven.getProject(DefaultMaven.java:553)
at
org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:467)
at org.apache.maven.DefaultMaven.getProjects(DefaultMaven.java:364)
... 11 more
Caused by: org.apache.maven.project.ProjectBuildingException: POM
'org.apache.tu
scany.sca:tuscany-sca' not found in repository: Unable to download the
artifact
from any repository
org.apache.tuscany.sca:tuscany-sca:pom:1.0.1-incubating
from the specified remote repositories:
central (http://repo1.maven.org/maven2)
for project org.apache.tuscany.sca:tuscany-sca
at
org.apache.maven.project.DefaultMavenProjectBuilder.findModelFromRepo
sitory(DefaultMavenProjectBuilder.java:573)
at
org.apache.maven.project.DefaultMavenProjectBuilder.assembleLineage(D
efaultMavenProjectBuilder.java:1257)
... 17 more
Caused by: org.apache.maven.artifact.resolver.ArtifactNotFoundException:
Unable
to download the artifact from any repository
org.apache.tuscany.sca:tuscany-sca:pom:1.0.1-incubating
from the specified remote repositories:
central (http://repo1.maven.org/maven2)
at
org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(De
faultArtifactResolver.java:197)
at
org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(De
faultArtifactResolver.java:73)
at
org.apache.maven.project.DefaultMavenProjectBuilder.findModelFromRepo
sitory(DefaultMavenProjectBuilder.java:526)
... 18 more
Caused by: org.apache.maven.wagon.ResourceDoesNotExistException: Unable to
downl
oad the artifact from any repository
at
org.apache.maven.artifact.manager.DefaultWagonManager.getArtifact(Def
aultWagonManager.java:324)
at
org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(De
faultArtifactResolver.java:185)
... 20 more
[INFO] ------------------------------------------------------------------------
[INFO] Total time: < 1 second
[INFO] Finished at: Mon Nov 05 20:45:25 GMT 2007
[INFO] Final Memory: 2M/38M
[INFO] ------------------------------------------------------------------------
Classpath in simple-callback-ws/README is wrong
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
The README has sample-simple-callback.jar in the class path but the jar
file
is actually called sample-simple-callback-ws.jar. As a result, the sample
does not run and throws:
Exception in thread "main" java.lang.NoClassDefFoundError:
simplecallback/Simple
CallbackClient
Once the jar file name is corrected, the sample runs fine.
Trivial - does not need fixing before release
=============================================
sample/osgi-supplychain/README
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Line 22 incorrectly states that the expected output is:
Work thread Thread[Thread-1,5,main] - Order, submitted, fulfilled,
shipped
However, lines 131 and 154 correctly state that the expected output is:
Work thread Thread[pool-1-thread-1,5,main] - Order, submitted,
fulfilled, sh
ipped
Line 22 is has the wrong thread name
Add link to Jira server on CHANGES file
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
The CHANGES file lists the Jiras that have been fixed. It might be nice to
add the URL of where the Jira server is located.
Not all the samples are listed in samples/README
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
The following samples are in the samples directory but not listed in the
samples/README file.
binding-echo
binding-echo-extension
binding-notification-broker
binding-notification-consumer
binding-notification-producer
helloworld-ws-reference-jms
helloworld-ws-reference-secure
helloworld-ws-service
implementation-crud
implementation-crud-extension
implementation-notification
implementation-pojo-extension
Instructions for running quote-xquery sample are incorrect
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
The instructions correctly list the command "ant run-server" to run the
server.
The instructions do not mention that you need to run the command "ant run"
to
run the client
implementation-pojo-extension sample is not complete
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Generally, the samples have a Java command line in the README for running
the
sample without ant. However, the implementation-pojo-extension/README does
not.
The command "ant run" does not work for the implementation-pojo-extension
sample
implementation-notification sample is not complete
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
The jar file in the target directory of the implementation-notification
sample
is named differently
(sample-implementation-notification-1.0.1-incubating.jar)
whereas all other sample jar files do not include the "-1.0.1-incubating"
version information
implementation-notification sample no *nix instructions
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
The implementation-notification/README file is missing the command line
for
*nix. The command is:
java -cp
../../lib/tuscany-sca-manifest.jar:target/sample-implementation-notific
ation.jar notification.TrafficAdvisoryClient
Note: I have assumed that the jar has been renamed (see above issue)
Thanks,
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
