Hi Fabio, On 23/09/2017 17:11, Fabio Estevam wrote: > On Sat, Sep 23, 2017 at 10:01 AM, Fabio Estevam <feste...@gmail.com> wrote: >> Hi Stefano, >> >> On Sat, Sep 23, 2017 at 5:43 AM, Stefano Babic <sba...@denx.de> wrote: >> >>> Max has already fixed apalis / colibri, see for example >>> http://patchwork.ozlabs.org/patch/817053/. I will apply Max's patches >>> and drop 5/6 from your series. Anyway, thanks for having thought to >>> these two boards, too. >> >> Yes, I saw Max's patches too. When I tried the same approach on >> cgtqmx6eval I got build failures: >> >> board/congatec/cgtqmx6eval/built-in.o: In function `setup_display': >> /home/fabio/u-boot-imx/board/congatec/cgtqmx6eval/cgtqmx6eval.c:632: >> undefined reference to `enable_ipu_clock' >> /home/fabio/u-boot-imx/board/congatec/cgtqmx6eval/cgtqmx6eval.c:633: >> undefined reference to `imx_setup_hdmi' >> >> It is true that Max's patches fix the warnings for Toradex boards, but >> if in future someone rework the IPU code like it is done in >> cgtqmx6eval, then failure would happen. >> >> So I thought that a more robust solution was to simply prevent making >> explicit calls to setup_display() from SPL like I did here. >> >> This also has the benefit to have the same solution across several mx6 >> boards. > > One more advantage of my proposal is that it does not rely on adding > logic to include/configs/.
You're right, I agree. > > This is particularly important when someone moves the IPU related > config symbols into Kconfig. > +1 Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot