Dear Wolfgang Denk,
> In message <4ca5d26d.2090...@emk-elektronik.de> you wrote:
>>> If this is really for all AT91 SoCs, then please feel free to
>>> introduce a common define (CONFIG_SYS_AT91 ?) and use that. Eventually
>>> you can clean up some other such #if's on the way.
>> That would have to be set either in each board.h file or in each at91*.h
>> file.
>
> Isn't there a central place?
>
>>> Probably there is a header file common to all AT91 SoCs when then can
>>> use a single such construct to #define the new variable so you don;t
>>> have to touch all the many board config files.
>> The only files I can see included in each instance are those of the kind
>> hardware.h, memory_map.h and similiar. The define does not really belong
>> in any of those.
I tried arch-at91/hardware.h. Apparently it gets included after
global_data.h. Same would be true for all files included inside hardware.h.
Without reordering the includes (which I don't want to do) the remaining
place would be each board's config file. Since all AT91 boards are broken
anyway right now; adding it could be left to the respective maintainers :)
> If no better place is found, we can even add this to <common.h> (we do
> similar things there already for CONFIG_MPC866_FAMILY, CONFIG_MPC86x,
> CONFIG_MPC8272_FAMILY, CONFIG_TQM8xxM, CONFIG_TQM8xxL, etc.
Into this chain?
#if defined(CONFIG_MPC852) || defined(CONFIG_MPC852T) || \
defined(CONFIG_MPC859) || defined(CONFIG_MPC859T) || \
defined(CONFIG_MPC859DSL) || \
defined(CONFIG_MPC866) || defined(CONFIG_MPC866T) || \
defined(CONFIG_MPC866P)
# define CONFIG_MPC866_FAMILY 1
#elif defined(CONFIG_MPC870) \
Ugly, but possible :)
Just hoping that everytime a new AT91 comes out, it will not be forgotten to be
added there ;)
Reinhard
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
