Dear Wolfgang Denk, >> The Qs that remain now are: >> >> 1. currently I see about 8 CONFIG_AT91SAMxxx defines required >> (not only 2 like above). The method is still undecided how to >> handle this. Add "CONFIG_AT91SAM9_FAMILY" to "common.h"? Or put >> all 8 defined() into "global_data.h" (would give 4 lines there)? > > You wille ventually need this in other locations as well, so please > add a single 4-line-#if to some appropriate header file; if there is > no better file for AT91 I will accept this for common.h
There is no at91 common header file that gets included BEFORE global_data.h, unfortunately. > >> 2. How many patches would this change need, and who would collect them? >> It affects at worst 3 areas: >> common.h, arm/global_data.h, at91/clock.c+timer.c --- >> Or is it ok to put that into one patch and add it later to my atmel tree? > > I see two patches: > > Patch 1 will change the #if and introduce CONFIG_AT91SAM9_FAMILY > instead. > > Patch 2 will fix at91/clock.c+timer.c Maybe there is a misunderstanding here. I see three patches 1. introduce CONFIG_AT91SAM9_FAMILY to common.h 2. add an #ifdef CONFIG_AT91SAM9_FAMILY to global_data.h with the required variables 3. change clock and timer. 2+3 combined in one patch? OK And I bet, this must be a patch series ;) Reinhard _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot