On Thu, May 26, 2022 at 01:55:42PM -0500, nick.hawk...@hpe.com wrote: > From: Nick Hawkins <nick.hawk...@hpe.com> > > Add basic support for the HPE GXP SoC. Reset the EHCI controller at > boot. > > Signed-off-by: Nick Hawkins <nick.hawk...@hpe.com> > --- > board/hpe/gxp/Kconfig | 47 +++++++++++++++++++++++++++++++++++++++ > board/hpe/gxp/Makefile | 1 + > board/hpe/gxp/gxp_board.c | 33 +++++++++++++++++++++++++++ > 3 files changed, 81 insertions(+) > create mode 100644 board/hpe/gxp/Kconfig > create mode 100644 board/hpe/gxp/Makefile > create mode 100644 board/hpe/gxp/gxp_board.c [snip] > +config GXP_ECC > + default n > + bool "Enable memory ECC protected"
"n" is the normal default, so you don't need to add it here. > + help > + Use half of memory to enable ECC protected The normal indentation is "<tab><space><space>". > diff --git a/board/hpe/gxp/gxp_board.c b/board/hpe/gxp/gxp_board.c > new file mode 100644 > index 0000000000..7fc1bf2fd6 > --- /dev/null > +++ b/board/hpe/gxp/gxp_board.c > @@ -0,0 +1,33 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * GXP timer driver > + * > + * (C) Copyright 2022 Hewlett Packard Enterprise Development LP. > + * Author: Nick Hawkins <nick.hawk...@hpe.com> > + * Author: Jean-Marie Verdun <ver...@hpe.com> > + */ > + > +#include <asm/io.h> > +#include <common.h> Here and elsewhere, <common.h> really just grabs a few other header files. Don't use it, and include what you need directly instead. -- Tom
signature.asc
Description: PGP signature
