Hi Steven,

Steven King wrote:
On Monday 12 July 2010 8:07:54 Greg Ungerer wrote:
Hi Jate,

Jate Sujjavanich wrote:
I have cherry picked the patch into my local 2.6.34 kernel. Using the
coldfire qspi driver, I the following error:

drivers/spi/coldfire_qspi.c: In function 'mcfqspi_irq_handler':
drivers/spi/coldfire_qspi.c:166: error: 'TASK_NORMAL' undeclared (first
use in this function) drivers/spi/coldfire_qspi.c:166: error: (Each
undeclared identifier is reported only once

It is solved by adding the following include to coldfire_sqpi.c:

#include <linux/sched.h>
That patch has already been pulled into Linus's tree. So I have
created a new patch with this fix. Currently sitting on the for-linus
(and for-next) branches of the m68knommu git tree.

Curious. The coldfire_qspi.c in Linus' v2.6.35-rc's, which has all the headers fully merged, builds just fine as is. (As did all of my 2.6.33/34 development builds with the original patch set) and others (Hi! Wilfried) are using the coldfire_qspi without reporting (atleast to me) a problem with this... Perhaps Jake missed something when cherry-picking?
That is to say, I think you are fixing something that isnt broken.

In that case I will back out that patch :-)

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     g...@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to