I just tried the 2.6.35-rc tree. I tried 527x and 5329 configurations in 
addition to my current 523x one.

What toolchain are you using? I am running 4.4.1 (Sourcery G++ Lite 4.4-216).


- Jate

-----Original Message-----
From: Steven King [mailto:sfk...@fdwdc.com] 
Sent: Tuesday, July 13, 2010 2:25 AM
To: uclinux-dev@uclinux.org
Cc: Greg Ungerer; Jate Sujjavanich
Subject: Re: [uClinux-dev] [PATCH] m68knommu: Coldfire QSPI platform support

On Monday 12 July 2010 8:07:54 Greg Ungerer wrote:
> Hi Jate,
>
> Jate Sujjavanich wrote:
> > I have cherry picked the patch into my local 2.6.34 kernel. Using the
> > coldfire qspi driver, I the following error:
> >
> > drivers/spi/coldfire_qspi.c: In function 'mcfqspi_irq_handler':
> > drivers/spi/coldfire_qspi.c:166: error: 'TASK_NORMAL' undeclared (first
> > use in this function) drivers/spi/coldfire_qspi.c:166: error: (Each
> > undeclared identifier is reported only once
> >
> > It is solved by adding the following include to coldfire_sqpi.c:
> >
> > #include <linux/sched.h>
>
> That patch has already been pulled into Linus's tree. So I have
> created a new patch with this fix. Currently sitting on the for-linus
> (and for-next) branches of the m68knommu git tree.

Curious.   The coldfire_qspi.c in Linus' v2.6.35-rc's, which has all the 
headers fully merged, builds just fine as is.    (As did all of my 2.6.33/34 
development builds with the original patch set) and others (Hi! Wilfried) are 
using the coldfire_qspi without reporting (atleast to me) a problem with 
this...  Perhaps Jake missed something when cherry-picking? 

That is to say, I think you are fixing something that isnt broken.

 
 
************************************************************************************
This footnote confirms that this email message has been scanned by
PineApp Mail-SeCure for the presence of malicious code, vandals & computer 
viruses.
************************************************************************************



_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to