On 05/ 4/12 08:08 AM, Rich Burridge wrote:
> Hi,
>
> Could I please get a code review for the changes for:
>
> 7166472 expect does not work with tclsh
> http://monaco.us.oracle.com/detail.jsf?cr=7166472
>
> Webrev is at:
>
> http://jurassic.us.oracle.com/~richb/7166472-v1/
This appears to basically be reverting the change for 6857103 and losing
the performance/benchmark gains it provided by using the 64-bit tcl by
default (leaving the 32-bit available on request).
Would it not be better to change expect to build 64-bit as well, instead
of reverting to 32-bit tclsh by default for all software? Or if that's
not possible, modify it to run /usr/bin/i86/tclsh instead of /usr/bin/tclsh?
(The library location and lack of 64-bit version implies it's private, but
the presence of a libexpect man page suggests it's public.)
--
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
