Alan is a tad busy at the moment, so could somebody else please re-review this one?
Thanks. -------- Original Message -------- Subject: Re: [userland-discuss] Code review request for CR #7166472 Date: Mon, 07 May 2012 08:46:57 -0700 From: Rich Burridge <[email protected]> To: Alan Coopersmith <[email protected]> CC: Userland-Discuss <[email protected]> On 05/ 4/12 02:28 PM, Alan Coopersmith wrote:
On 05/ 4/12 08:08 AM, Rich Burridge wrote:Hi, Could I please get a code review for the changes for: 7166472 expect does not work with tclsh http://monaco.us.oracle.com/detail.jsf?cr=7166472 Webrev is at: http://jurassic.us.oracle.com/~richb/7166472-v1/This appears to basically be reverting the change for 6857103 and losing the performance/benchmark gains it provided by using the 64-bit tcl by default (leaving the 32-bit available on request).
You're right. Bad idea.
Would it not be better to change expect to build 64-bit as well, instead of reverting to 32-bit tclsh by default for all software? Or if that's not possible, modify it to run /usr/bin/i86/tclsh instead of /usr/bin/tclsh?
I did both. I still needed to modify all the /usr/demo/expect scripts as the "exec tclsh" line is executed by /bin/sh (which is 32 bit). New webrev at: http://jurassic.us.oracle.com/~richb/7166472-v2/ Thanks. _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
