Rich Burridge wrote:

>   http://jurassic.us.oracle.com/~richb/7166472-v2/

Makefile:

  - Could you use $(MACH$(BITS)) instead of splitting out CONFIGURE_OPTIONS
    into 32- and 64-bit specific sections?  You might still need the -m64
    specifically.

  - Now that you're delivering 64-bit expect bits, shouldn't it simply work
    to use the 64-bit tclsh?  If not, isn't that the real bug here?

expect.p5m:

  - Nothing wrong with the changes here, but could you make the files in
    demo executable?  Seems silly to be required to run "sh /usr/demo/...",
    and given the find statement in the makefile, they're clearly intended
    to be shipped with the execute bits turned on.

Thanks,
Danek
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to