(Danek and Alan have been helping me progress this offline - thanks!).
On 05/14/2012 12:30 PM, Danek Duvall wrote:
Rich Burridge wrote:
http://jurassic.us.oracle.com/~richb/7166472-v2/
Makefile:
- Could you use $(MACH$(BITS)) instead of splitting out CONFIGURE_OPTIONS
into 32- and 64-bit specific sections? You might still need the -m64
specifically.
Yes, that works nicely. So changed.
- Now that you're delivering 64-bit expect bits, shouldn't it simply work
to use the 64-bit tclsh? If not, isn't that the real bug here?
Yes it is. See the latest Evaluation comment in the Bugster CR.
A patch to the Tcl init.tcl file to fix this, has been created.
expect.p5m:
- Nothing wrong with the changes here, but could you make the files in
demo executable? Seems silly to be required to run "sh /usr/demo/...",
and given the find statement in the makefile, they're clearly intended
to be shipped with the execute bits turned on.
So changed.
New webrev at:
http://jurassic.us.oracle.com/~richb/7166472-v3/
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss