pretty sure SMB is super popular - it is just that for the cases we
typically engage in SMB isn't used as the protocol to access data :)

Agree with the rest of that

Thanks

On Mon, Mar 22, 2021 at 11:13 AM Mark Payne <marka...@hotmail.com> wrote:
>
> Jens,
>
> In order to review & merge a PR, there are two important things that need to 
> happen:
>
> 1. A NiFi committer must review the code to make sure that the changes are 
> safe, make sense, conducive with the architecture, is adhering to best 
> practices, doesn’t break automated tests, etc.
> 2. The code needs to be tested - typically this is accomplished both manually 
> and in an automated sense. Sometimes only manually, sometimes automated.
>
> For this case, we really would need someone other than the contributor who 
> put up the PR to test this manually to verify that it works. The problem is 
> that SMB isn’t really that popular, I don’t think. So we would need someone 
> who can verify that the changes work as desired. This doesn’t need to be a 
> committer.
>
> If you’re able to build that branch and verify the changes and then report 
> back any positive or negative findings, that can go a long way to help in the 
> review process.
>
> Thanks
> -Mark
>
> On Mar 22, 2021, at 4:03 AM, Jens M. Kofoed <jmkofoed....@gmail.com> wrote:
>
> Hi
>
> The following JIRA: https://issues.apache.org/jira/browse/NIFI-7863, was 
> created October 1, 2020 and the user Jaya has created a PR October 9, 2020. 
> but nothing have happens since.
>
> Are there someone in the community which is able to help implement a fix?
> We had looked forward to see the fix included in 1.13, but unfortunately it 
> is not.
>
> Kind regards
> Jens M. Kofoed
>
>
>
>

Reply via email to